Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta README #4

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Meta README #4

merged 3 commits into from
Nov 19, 2021

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Nov 18, 2021 •
edited
Loading

I'm not sure if this fits here or https://github.com/MeltanoLabs/.github/blob/main/profile/README.md?

I took a stab at documenting the expectations, roles, permissions, maintenance status, contribution steps, etc. based on some of the comments from https://gitlab.com/meltano/meta/-/issues/73

TODO:

  • I dont know how the current process works for migrating an existing connector to MeltanoLabs, I'd like to at least add an overview and direct people to submit and issue for and admin to do it.
  • I couldnt find the issue where we decided on the Teams structure and what permissions are given to each role but this breakdown seemed right. Were we planning to create a team per repo like "tap-google-analytics-contributor" and "..-maintainer"

maintainer: maintain
contributor: write
community member (anyone): read
admin (internal): admin

@pnadolny13 pnadolny13 marked this pull request as ready for review November 19, 2021 19:26
tayloramurphy
tayloramurphy reviewed Nov 19, 2021
View reviewed changes
@tayloramurphy
Copy link
Contributor

LGTM @pnadolny13 - feel free to merge or we can wait for AJ's feedback. Either way, this is a great first iteration.

aaronsteers
aaronsteers approved these changes Nov 19, 2021
View reviewed changes
Copy link

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnadolny13 - This looks great, a very nice iteration!

@pnadolny13 pnadolny13 merged commit 465ef4e into main Nov 19, 2021
@pnadolny13 pnadolny13 changed the title Draft: Meta README Meta README Nov 19, 2021
@pnadolny13 pnadolny13 mentioned this pull request Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tayloramurphy tayloramurphy tayloramurphy approved these changes

@aaronsteers aaronsteers aaronsteers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnadolny13 @tayloramurphy @aaronsteers